Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional CSE benchmarks #81

Merged
merged 7 commits into from
Oct 17, 2022

Conversation

brocksam
Copy link
Contributor

This PR:

  • Introduces a new CSE benchmark based on the "baby example" from Griewank & Walther (2008). This is a simple example function in two variables that requires careful selection of the operation order in the common subexpressions to represent the original expression in its simplest form.
  • Introduces a new CSE benchmark based on the "lighthouse example" from Griewank & Walther (2008). This is a simple example matrix function in four variables where one of the two matrix entries is a common subexpression of the other.
  • Slightly refactors the existing time_cse benchmark.

This PR introduces some test_ methods in addition to the time_ methods that will be run by asv. These are included here for bookkeeping with the hope that in the future SymPy's benchmarking will support a wider range of benchmark types (see this SymPy mailing list thread and this asv GitHub issue).

@moorepants
Copy link
Member

LGTM

@moorepants moorepants merged commit 64866c6 into sympy:master Oct 17, 2022
@brocksam brocksam added the CZI: Codegen Sam Brockie's CZI-funded postdoc work on codegen and biomechanics label Jan 10, 2023
@brocksam brocksam deleted the add-additional-cse-benchmarks branch February 21, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CZI: Codegen Sam Brockie's CZI-funded postdoc work on codegen and biomechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants